Conversation
codeCollision4
requested review from
AdvancedImagingUTSW,
annie-xd-wang and
zacsimile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .MOV and .MVR functions have now been wrapped in try, except blocks. It is possible that GCSError(e) might throw a syntax error but it is supposed to print a verbose statement about why the error occurred. Otherwise I did the axis reset directly via the hardcoded axis for each once an exception was encountered. Please double check I did not mix any axis numbers up in the .RES, .MOV, .MVR calls. If there is a better way to code this that is less hardcoded please let me know. Also please check that I did not miss any calls to move the stage elsewhere. I tagged everyone but I think only one of you needs to review it.