Logging on Model, Controller, and View#76
Merged
Conversation
Attempt at adding logging features
attempted logging
attempt at logging
corrected logging
corrected logging
logging all devices
finished logging
logging on sub_controllers
codeCollision4
suggested changes
Jun 6, 2022
Contributor
codeCollision4
left a comment
codeCollision4
left a comment
There was a problem hiding this comment.
Update the logger.error -> logger.exception where specified and then this will be good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sampath Logging attempt on Model, Controller, and View