Add photometrics camera#505
Merged
Merged
Conversation
Co-Authored-By: DaetwylerStephan <16138734+DaetwylerStephan@users.noreply.github.com> Co-Authored-By: Zach Marin <zacsimile@users.noreply.github.com>
Collaborator
|
Confirmed tested on Jinlong's scope. |
AdvancedImagingUTSW
approved these changes
Jul 11, 2023
Collaborator
AdvancedImagingUTSW
left a comment
AdvancedImagingUTSW
left a comment
There was a problem hiding this comment.
So long as any problems are isolated to @JinlongL or Reto's microscopes, we can deal with them there.
Collaborator
|
Interestingly, the pvcam python module comes with unit tests, which are being run by GitHub. If we flag these as hardware, we should probably be okay. |
Collaborator
|
Good call. Updated. |
Codecov Report
@@ Coverage Diff @@
## develop #505 +/- ##
===========================================
- Coverage 46.78% 46.11% -0.68%
===========================================
Files 159 162 +3
Lines 15140 15636 +496
===========================================
+ Hits 7083 7210 +127
- Misses 8057 8426 +369
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.