Add support for free-running mode with Hamamatsu cameras#1085
Merged
AdvancedImagingUTSW merged 4 commits intoApr 5, 2025
Conversation
Collaborator
Author
|
The GUI has been updated as below. Choose "Internal" trigger mode will run the camera in Free-running mode. |
AdvancedImagingUTSW
requested review from
AdvancedImagingUTSW and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
test/controller/sub_controllers/test_camera_settings.py:71
- The removal of assertions for trigger_source, trigger_active, and readout_speed means that these settings are no longer verified in this test. Please ensure that the new behavior is adequately covered by other tests or add new tests verifying the proper configuration of trigger modes.
- assert (self.camera_settings.trigger_source == camera_config_dict["trigger_source"])
src/navigate/model/devices/camera/hamamatsu.py:205
- The init method calls set_trigger_mode without specifying a trigger_source, which defaults to "External" even if free-running mode (internal) is intended. Consider passing the appropriate trigger_source value from the configuration to ensure the desired camera mode is set.
def set_trigger_mode(self, trigger_source="External"):
src/navigate/view/main_window_content/camera_tab.py:186
- [nitpick] This condition limits variable retrieval to LabelInput widgets. If other widget types are used or added in the future, consider expanding the handling logic or documenting why only LabelInput instances are processed.
if isinstance(widget, LabelInput):
| result = self.set_binning(binning) | ||
| return result | ||
|
|
||
| def set_trigger_mode(self, trigger_source:str="External") -> None: |
There was a problem hiding this comment.
The set_trigger_mode method is currently a stub with a pass statement. Consider raising a NotImplementedError or providing a basic implementation to ensure that calls to this method do not fail silently.
AdvancedImagingUTSW
approved these changes
Apr 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for running Hamamatsu cameras in free-running mode. Below is a screenshot of the updated GUI.
