add Ximea camera class file#1069
Merged
AdvancedImagingUTSW merged 10 commits intoMar 20, 2025
Merged
Conversation
write image to shared data buffer
Collaborator
|
Awesome. Thank you so much Annie. |
AdvancedImagingUTSW
approved these changes
Mar 20, 2025
Collaborator
AdvancedImagingUTSW
left a comment
AdvancedImagingUTSW
left a comment
There was a problem hiding this comment.
@annie-xd-wang - Another case where we will need to update the documentation. We should now provide information on the ximea camera...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new device class file has been tested with software trigger and is working as expected. However, the device requires setting binning before configuring the ROI, which is the opposite sequence of our current workflow. We need to verify whether this change is compatible with other camera devices.
Additionally, the valid ROI values are somewhat tricky. It may be necessary to update the camera settings controller to improve user-friendliness.
We may need to have a discussion before merging this into our codebase.