Skip to content

Type hinting the model...#1016

Merged
AdvancedImagingUTSW merged 4 commits into
developfrom
typehinting2
Oct 29, 2024
Merged

Type hinting the model...#1016
AdvancedImagingUTSW merged 4 commits into
developfrom
typehinting2

Conversation

@AdvancedImagingUTSW
Copy link
Copy Markdown
Collaborator

And some related methods and classes that it calls. Slowly eliminating perceived problems by Pycharm...

And some related methods and classes that it calls. Slowly eliminating perceived problems by Pycharm...
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 91.07143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.30%. Comparing base (fd79b51) to head (8693802).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/navigate/model/model.py 90.69% 4 Missing ⚠️
src/navigate/model/features/common_features.py 33.33% 2 Missing ⚠️
src/navigate/model/features/remove_empty_tiles.py 0.00% 2 Missing ⚠️
src/navigate/model/data_sources/__init__.py 0.00% 1 Missing ⚠️
src/navigate/model/features/adaptive_optics.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1016      +/-   ##
===========================================
+ Coverage    54.26%   54.30%   +0.03%     
===========================================
  Files          180      180              
  Lines        20282    20302      +20     
===========================================
+ Hits         11006    11024      +18     
- Misses        9276     9278       +2     
Flag Coverage Δ
unittests 54.30% <91.07%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 365fbad into develop Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant