Adding tests for SVG and fixing height/width bug#1202
Merged
Sub6Resources merged 1 commit intoSub6Resources:masterfrom May 9, 2023
Merged
Adding tests for SVG and fixing height/width bug#1202Sub6Resources merged 1 commit intoSub6Resources:masterfrom
Sub6Resources merged 1 commit intoSub6Resources:masterfrom
Conversation
Contributor
jlyonsmith
commented
Dec 7, 2022
jlyonsmith
commented
- Reduced code by putting attributes in a local
- Add { } around if's to make code friendlier to code coverage
- Add more unit tests to get to 57.4%
- Fix height/width bug in svgTagRender (using width for height)
- Add height/width to the svgDataImagerRender for Picture.string
- Refactored unit tests to simplify and reduce code
- Add coverage and scratch directories to .gitignore
Contributor
Author
|
Is there nobody out there to approve this merge? |
Sub6Resources
requested changes
May 9, 2023
- Reduced code by putting attributes in a local
- Add { } around if's to make code friendlier to code coverage
- Add more unit tests to get to 57.4%
- Fix height/width bug in svgTagRender (using width for height)
- Add height/width to the svgDataImagerRender for Picture.string
- Refactored unit tests to simplify and reduce code
- Add coverage and scratch directories to .gitignore
Contributor
Author
|
|
Owner
|
I'm gonna merge this now actually and resolve conflicts in #1176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.