Skip to content

fix: Fix issue with font scaling introduced in 3.0.0-alpha.6#1173

Merged
Sub6Resources merged 2 commits intomasterfrom
fix/device-pixel-ratio
Oct 21, 2022
Merged

fix: Fix issue with font scaling introduced in 3.0.0-alpha.6#1173
Sub6Resources merged 2 commits intomasterfrom
fix/device-pixel-ratio

Conversation

@Sub6Resources
Copy link
Copy Markdown
Owner

@Sub6Resources Sub6Resources commented Oct 20, 2022

Fixes #1170

I inadvertently used Text.rich, which doesn't handle accessibility or font scaling very well, instead of RichText in CssBoxWidget. This reverts that issue.

@Sub6Resources Sub6Resources added this to the 3.0.0 milestone Oct 20, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Base: 51.41% // Head: 49.68% // Decreases project coverage by -1.73% ⚠️

Coverage data is based on head (1802309) compared to base (6571e3b).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 1802309 differs from pull request most recent head 1ed9643. Consider uploading reports for the commit 1ed9643 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
- Coverage   51.41%   49.68%   -1.74%     
==========================================
  Files          19       18       -1     
  Lines        2641     2681      +40     
==========================================
- Hits         1358     1332      -26     
- Misses       1283     1349      +66
Impacted Files Coverage Δ
lib/src/style/fontsize.dart 56.25% <ø> (ø)
lib/src/css_box_widget.dart 64.33% <100.00%> (+0.05%) ⬆️
lib/html_parser.dart 73.34% <0.00%> (-10.62%) ⬇️
lib/src/styled_element.dart 79.14% <0.00%> (-1.07%) ⬇️
lib/style.dart 84.77% <0.00%> (-0.60%) ⬇️
lib/src/css_parser.dart 13.64% <0.00%> (-0.20%) ⬇️
lib/src/style/marker.dart
lib/custom_render.dart 51.57% <0.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erickok
Copy link
Copy Markdown
Contributor

erickok commented Oct 21, 2022

This is really unexpected to me... But glad it got fixed.

erickok
erickok previously approved these changes Oct 21, 2022
View reviewed changes
@Sub6Resources Sub6Resources merged commit c75e0df into master Oct 21, 2022
@Sub6Resources Sub6Resources deleted the fix/device-pixel-ratio branch October 21, 2022 17:54
@erickok erickok mentioned this pull request Oct 28, 2022
Closed
@kbosselmansh
Copy link
Copy Markdown

kbosselmansh commented Jan 18, 2023

@Sub6Resources Is there a plan to push a new alpha release with this fix (3.0.0-alpha.7??)

@Sub6Resources
Copy link
Copy Markdown
Owner Author

Sub6Resources commented May 9, 2023

@kbosselmansh Watch for 3.0.0-beta.1, coming hopefully before the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@erickok erickok erickok left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Text size wildly varying in alpha 6

3 participants

@Sub6Resources @erickok @kbosselmansh