Conversation
- flutter_html@3.0.0-alpha.6 - flutter_html_audio@3.0.0-alpha.4 - flutter_html_iframe@3.0.0-alpha.4 - flutter_html_table@3.0.0-alpha.4 - flutter_html_math@3.0.0-alpha.4 - flutter_html_video@3.0.0-alpha.5 - flutter_html_all@3.0.0-alpha.6 - flutter_html_svg@3.0.0-alpha.4
Codecov ReportBase: 49.70% // Head: 49.70% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1149 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 18 18
Lines 2682 2682
=======================================
Hits 1333 1333
Misses 1349 1349 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
erickok
left a comment
erickok
left a comment
There was a problem hiding this comment.
All good, with one minor remark.
| sdk: flutter | ||
| html: '>=0.15.0 <1.0.0' | ||
| flutter_html: '>=3.0.0-alpha.3 <4.0.0' | ||
| flutter_html: ^3.0.0-alpha.6 |
There was a problem hiding this comment.
Whilst not a big problem at all, as they are dependencies on our own libs, this does make it slightly less free for our users to, for example, use a flutter_html (core) 3.1.0 with flutter_html_video 3.0. Therefor, when we publish minor releases such as 3.1.0 we need to also release updates to our sub-libraries. Again, not a big problem at all but if melos supports it we might want to keep the less restrictive <4.0.0.
There was a problem hiding this comment.
That's a good point. Unfortunately, I'm not sure that melos supports that, and I could see how that is a little more complex to implement on their end.
I'll look a little deeper into that though and open a ticket with melos if there isn't one already, to see if that's something they're considering.
2 participants
Just ran a
melos versionand updated the primary changelog. After this is approved and merged, I'll publish the new package versions.