[API-8172, API-8202] Adds $promotions and moves $iata_carrier_code - #119
Merged
Merged
Conversation
iprysiazhnyi-sift
marked this pull request as ready for review
May 7, 2025 13:47
echumak-sift
approved these changes
May 7, 2025
echumak-sift
left a comment
echumak-sift
left a comment
Contributor
There was a problem hiding this comment.
I posted 2 comments, lgtm besides of that
| /** | ||
| * Sets the IATA carrier code for the flight segment. | ||
| * | ||
| * <p>This field should only be set when the booking type is {@code $flight}.</p> |
Contributor
There was a problem hiding this comment.
do you think we need to assess where enhanced validation is needed and what that effort may be as a possible tech debt project?
| @Expose @SerializedName("$currency_code") private String currencyCode; | ||
| @Expose @SerializedName("$exchange_rate") private ExchangeRate exchangeRate; | ||
| @Expose @SerializedName("$quantity") private Long quantity; | ||
| @Expose @SerializedName("$iata_carrier_code") private String iataCarrierCode; |
Contributor
There was a problem hiding this comment.
are we sure nobody started using $iata_carrier_code with booking $booking?
advornichenko-sift
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Keep
sift-javaup to date with latest API changesTechnical overview
$promotionsfield to the$update_accountevent$iata_carrier_codefrom$bookingobject to the$segmentobject level