Conversation
xavierpinho
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A C# auto property can bet set within a constructor even if the property is declared with a
getaccessor only (these properties are "readonly"). So when we (manually) implement an auto property, we currently account for such set accesses when the access is within an assignment expression; but we must also account for them within pre/post increment/decrement expressions.This PR extends, for pre/post increment/decrement expressions, the rewriting behaviour that already exists for assignment expressions. See the 2 new test cases.
Note: the code could have been more reusable if
PrefixUnaryExpressionSyntaxandPostfixUnaryExpressionSyntaxhad a common base class… or if we create an "adaptor" for these classes as we do for certain other syntaxes (but creating the adaptor is only worth it if we see this "pattern" occurring more often).