Update IsOpen and Close in ChooseOption.simba#28
Merged
Conversation
Changed "IsOpen" to use "Find" instead of "__Find" so that the option box boundaries will be set after "IsOpen" is called. I don't think this should cause issues since "Find" has a call to the other "__Find" function inside of it. In "Close" function I simplified the expression on line 412 of original to the equivalent expression: (dir.T-Pi/3) + Random()*(2*Pi/3); In "Close" function, I also added a piece of code to detect when the option box is within a few pixels of the left boundary of the client and over 500 pixels tall. If the option box is all the way to the left, you can not clear it by moving the mouse that direction, and if the option box is taller than 500 pixels it usually means the "Cancel" option has been bumped off the bottom, so the only way to clear it is to move the mouse to the right. This code snippet will force the move direction to an angle between the top right corner and bottom right corner of the option box, when the previous conditions are detected.
Corrected trig functions for dir.T assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed "IsOpen" to use "Find" instead of "__Find" so that the option box boundaries will be set after "IsOpen" is called. I don't think this should cause issues since "Find" has a call to the other "__Find" function inside of it.
In "Close" function I simplified the expression on line 412 of original to the equivalent expression: (dir.T-Pi/3) + Random()(2Pi/3);
In "Close" function, I also added a piece of code to detect when the option box is within a few pixels of the left boundary of the client and over 500 pixels tall. If the option box is all the way to the left, you can not clear it by moving the mouse that direction, and if the option box is taller than 500 pixels it usually means the "Cancel" option has been bumped off the bottom, so the only way to clear it is to move the mouse to the right. This code snippet will force the move direction to an angle between the top right corner and bottom right corner of the option box, when the previous conditions are detected.