Fix(bigquery): Pass catalog when checking for clustering key changes#3498
Merged
Conversation
erindru
force-pushed
the
erin/fix-bq-catalog
branch
2 times, most recently
from
5c1b6ff to
998b50d
Compare
erindru
force-pushed
the
erin/fix-bq-catalog
branch
from
998b50d to
0d69825
Compare
erindru
commented
Dec 10, 2024
| - main | ||
| #- clickhouse-cloud | ||
| #- athena | ||
| #filters: |
Collaborator
Author
There was a problem hiding this comment.
todo: revert
note that Snowflake also inherits ClusteredByMixin so ive enabled Snowflake tests for this PR too
erindru
commented
Dec 10, 2024
| current_table = exp.to_table(current_table_name) | ||
| target_table = exp.to_table(target_table_name) | ||
|
|
||
| current_table_schema = schema_(current_table.db, catalog=current_table.catalog) |
Collaborator
Author
There was a problem hiding this comment.
I observed that this was the function that the SnapshotEvaluator uses when it calls get_data_objects() to build a schema-with-catalog Table object.
The Table object cant be passed directly or to_schema() produces a db.table value instead of a catalog.db value
izeigerman
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.