Skip to content

Fix: Various Databricks related fixes#1036

Merged
eakmanrq merged 9 commits into
mainfrom
eakmanrq/fixes_spark
Jun 26, 2023
Merged

Fix: Various Databricks related fixes#1036
eakmanrq merged 9 commits into
mainfrom
eakmanrq/fixes_spark

Conversation

@eakmanrq
Copy link
Copy Markdown
Collaborator

@eakmanrq eakmanrq commented Jun 26, 2023

Note: This PR has Databricks do a non-transactional delete + insert due to issues with dynamic insert/overwrite on Unity catalog tables. Once a REPLACE WHERE bug is fixed we will be switching to that which will make it atomic again.

The USE CATALOG approach from before only worked if SQL was being executed. So if you had a Dataframe then that catalog would not be used. The setCurrentCatalog works across both SQL and Dataframe API.

@eakmanrq eakmanrq requested review from a team and izeigerman June 26, 2023 18:03
Comment thread sqlmesh/core/engine_adapter/base.py Outdated
Comment thread sqlmesh/core/snapshot/evaluator.py Outdated
@eakmanrq eakmanrq merged commit 6cc26f8 into main Jun 26, 2023
@eakmanrq eakmanrq deleted the eakmanrq/fixes_spark branch June 26, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants