Skip to content

More fork safety #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 9 commits into from
Mar 8, 2026
Merged

More fork safety #7380

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6217ad6
apply more allow_threads
youknowone Mar 7, 2026
6b6138b
Simplify STW thread state transitions
youknowone Mar 7, 2026
396fec9
Representable for ThreadHandle
youknowone Mar 7, 2026
9fe70f2
Set ThreadHandle state to Running in parent thread after spawn
youknowone Mar 7, 2026
e37b15f
Set ThreadHandle state to Running in parent thread after spawn
youknowone Mar 7, 2026
cfd7f01
Add debug_assert for thread state in start_the_world
youknowone Mar 8, 2026
1b97419
Unskip now-passing test_get_event_loop_thread and test_start_new_thre…
youknowone Mar 7, 2026
1ba2821
Wrap IO locks and file ops in allow_threads
youknowone Mar 8, 2026
ca41577
Use std::sync for thread start/ready events
youknowone Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Representable for ThreadHandle
  • Loading branch information
@youknowone
youknowone committed Mar 8, 2026
commit 396fec96b97435bbc533676e904ce952b94b60ad
12 changes: 11 additions & 1 deletion crates/vm/src/stdlib/thread.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,7 +1185,7 @@ pub(crate) mod _thread {
done_event: Arc<(parking_lot::Mutex<bool>, parking_lot::Condvar)>,
}

#[pyclass]
#[pyclass(with(Representable))]
impl ThreadHandle {
fn new(vm: &VirtualMachine) -> Self {
let inner = Arc::new(parking_lot::Mutex::new(ThreadHandleInner {
Expand Down Expand Up @@ -1427,6 +1427,16 @@ pub(crate) mod _thread {
}
}

impl Representable for ThreadHandle {
fn repr_str(zelf: &Py<Self>, _vm: &VirtualMachine) -> PyResult<String> {
let ident = zelf.inner.lock().ident;
Ok(format!(
"<{} object: ident={ident}>",
zelf.class().slot_name()
))
}
}

#[pyfunction]
fn start_joinable_thread(
mut f_args: FuncArgs,
Expand Down