Skip to content

Add vectorcall (PEP 590) dispatch for function calls #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
Mar 3, 2026
Merged

Add vectorcall (PEP 590) dispatch for function calls #7329

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8175bb7
Add vectorcall (PEP 590) dispatch for function calls
youknowone Mar 3, 2026
2226ae8
Optimize vectorcall: move args instead of clone, use vectorcall in sp…
youknowone Mar 3, 2026
981dafd
Auto-format: cargo fmt --all
github-actions[bot] Mar 3, 2026
4d8cf97
Fix vectorcall_native_function kwarg slice out-of-bounds
youknowone Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix vectorcall_native_function kwarg slice out-of-bounds 
When needs_self was true and kwargs were present, pos_args only
contained positional args (self + original positionals) but
from_vectorcall expected kwarg values to follow in the slice.

Build the full args array (self + all original args including kwarg
values) before passing to from_vectorcall.
  • Loading branch information
@youknowone
youknowone committed Mar 3, 2026
commit 4d8cf97452fd9f9dad64832a20d56a9d46fc4a10
19 changes: 4 additions & 15 deletions crates/vm/src/builtins/builtin_func.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,21 +243,10 @@ fn vectorcall_native_function(

let func_args = if needs_self {
let self_obj = zelf.zelf.as_ref().unwrap().clone();
let total_pos = nargs + 1;
let mut pos_args = Vec::with_capacity(total_pos);
pos_args.push(self_obj);
pos_args.extend(args.into_iter().take(nargs));

if let Some(kwnames_slice) = kwnames {
let kwargs =
FuncArgs::from_vectorcall(&pos_args, total_pos, Some(kwnames_slice)).kwargs;
FuncArgs {
args: pos_args,
kwargs,
}
} else {
FuncArgs::from(pos_args)
}
let mut all_args = Vec::with_capacity(args.len() + 1);
all_args.push(self_obj);
all_args.extend(args);
FuncArgs::from_vectorcall(&all_args, nargs + 1, kwnames)
} else {
FuncArgs::from_vectorcall(&args, nargs, kwnames)
};
Expand Down
Loading