Merged
Conversation
Contributor
📝 WalkthroughWalkthroughRemoved Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant PyObject
participant VM
participant TypeUtils
Caller->>PyObject: object_isinstance(obj, cls)
alt cls is a type
PyObject->>TypeUtils: subtype check (is subclass)
TypeUtils-->>PyObject: result
else cls is not a type
PyObject->>VM: get_attribute_opt(obj, "__class__")
VM-->>PyObject: class_obj or None
alt class_obj found
PyObject->>TypeUtils: abstract_issubclass(class_obj, cls)
TypeUtils-->>PyObject: result
else not found
PyObject-->>Caller: return False
end
end
PyObject-->>Caller: final bool
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The optimization to skip __class__ lookup based on getattro check was incorrect: a class can override __class__ as a property while still using standard __getattribute__. Revert to always performing the lookup, matching CPython's object_isinstance behavior.
youknowone
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/vm/src/protocol/object.rs (1)
579-607: Add focused regression tests for__class__-drivenisinstancesemantics.Given this revert fixes a prior optimization, please add coverage for objects overriding
__getattribute__/__class__to prevent future regressions in this path.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/vm/src/protocol/object.rs` around lines 579 - 607, Add focused regression tests that exercise object_isinstance's fallback path when instances override __getattribute__ or __class__; create tests that call isinstance(obj, SomeType) where obj provides a custom __getattribute__ and a dynamic __class__ attribute so the branch that uses vm.get_attribute_opt(self.to_owned(), identifier!(vm, __class__)) and then calls abstract_issubclass or PyTypeRef::try_from_object is executed; specifically target the code paths in object_isinstance (the branch guarded by let Some(i_cls) = vm.get_attribute_opt(...)) and ensure both the i_cls Type conversion (PyTypeRef::try_from_object) and the abstract_issubclass call are covered to detect regressions of the reverted optimization.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@crates/vm/src/protocol/object.rs`:
- Around line 579-607: Add focused regression tests that exercise
object_isinstance's fallback path when instances override __getattribute__ or
__class__; create tests that call isinstance(obj, SomeType) where obj provides a
custom __getattribute__ and a dynamic __class__ attribute so the branch that
uses vm.get_attribute_opt(self.to_owned(), identifier!(vm, __class__)) and then
calls abstract_issubclass or PyTypeRef::try_from_object is executed;
specifically target the code paths in object_isinstance (the branch guarded by
let Some(i_cls) = vm.get_attribute_opt(...)) and ensure both the i_cls Type
conversion (PyTypeRef::try_from_object) and the abstract_issubclass call are
covered to detect regressions of the reverted optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrong optimization
Summary by CodeRabbit