Skip to content

Add CI step for checking redundant test patches #7126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Feb 15, 2026
Merged

Add CI step for checking redundant test patches #7126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e7dfac3
Basic script to detect leftover patches
ShaharNaveh Feb 14, 2026
f0e5abb
Add CI step
ShaharNaveh Feb 14, 2026
7bdefc5
Checkout code
ShaharNaveh Feb 14, 2026
3fa7178
Merge remote-tracking branch 'upstream/main' into lint-script-patches
ShaharNaveh Feb 14, 2026
9e179aa
Merge remote-tracking branch 'upstream/main' into lint-script-patches
ShaharNaveh Feb 15, 2026
0da173a
coderabbit review
ShaharNaveh Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
coderabbit review
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Feb 15, 2026
commit 0da173a88437440b39a8759b71dfd1d1d1f9284a
1 change: 0 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,6 @@ jobs:
- name: Check for redundant test patches
run: python scripts/check_redundant_patches.py

- uses: actions/checkout@v6.0.2
- uses: dtolnay/rust-toolchain@stable
with:
components: clippy
Expand Down
2 changes: 1 addition & 1 deletion scripts/check_redundant_patches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def main():
try:
tree = ast.parse(contents)
except SyntaxError:
pass
continue

for node in ast.walk(tree):
Comment thread
coderabbitai[bot] marked this conversation as resolved.
if not isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef)):
Expand Down
Loading