Skip to content

PyStructSequence Compatibility #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Dec 5, 2025
Merged

PyStructSequence Compatibility #6327

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ad536e
Fix local time
youknowone Dec 5, 2025
a5aa409
PyStructSequence
youknowone Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix local time
  • Loading branch information
@youknowone
youknowone committed Dec 5, 2025
commit 5ad536e030d0c3b9fe304a8cf674a4a1aee8df9c
11 changes: 9 additions & 2 deletions crates/vm/src/stdlib/time.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,9 @@ mod decl {
/// Construct a localtime from the optional seconds, or get the current local time.
fn naive_or_local(self, vm: &VirtualMachine) -> PyResult<NaiveDateTime> {
Ok(match self {
Self::Present(secs) => pyobj_to_date_time(secs, vm)?.naive_utc(),
Self::Present(secs) => pyobj_to_date_time(secs, vm)?
.with_timezone(&chrono::Local)
.naive_local(),
Self::Missing => chrono::offset::Local::now().naive_local(),
})
}
Expand Down Expand Up @@ -323,7 +325,12 @@ mod decl {
#[pyfunction]
fn mktime(t: PyStructTime, vm: &VirtualMachine) -> PyResult<f64> {
let datetime = t.to_date_time(vm)?;
let seconds_since_epoch = datetime.and_utc().timestamp() as f64;
// mktime interprets struct_time as local time
let local_dt = chrono::Local
.from_local_datetime(&datetime)
.single()
.ok_or_else(|| vm.new_overflow_error("mktime argument out of range"))?;
let seconds_since_epoch = local_dt.timestamp() as f64;
Ok(seconds_since_epoch)
}

Expand Down