Skip to content

Fix sqlite connection reinitialization #6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 7 commits into from
Nov 22, 2025
Merged

Fix sqlite connection reinitialization #6288

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f47839b
Fix sqlite connection reinitialization
ever0de Nov 21, 2025
b3d45ae
Align sqlite connection reinit with CPython
ever0de Nov 21, 2025
216ab89
Enable sqlite test_connection_bad_reinit
ever0de Nov 21, 2025
5150186
Fix sqlite reinit flag without threading
ever0de Nov 21, 2025
b2f3adf
Update crates/stdlib/src/sqlite.rs
youknowone Nov 22, 2025
ece048d
Use stronger memory ordering for initialized flag synchronization
ever0de Nov 22, 2025
c9fc8a7
Auto-format code [skip ci]
github-actions[bot] Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use stronger memory ordering for initialized flag synchronization 
Apply code review feedback to use Ordering::AcqRel for the swap operation
and Ordering::Release for the store operation to ensure proper
synchronization across threads when setting the initialized flag.
  • Loading branch information
@ever0de
ever0de committed Nov 22, 2025
commit ece048d0be2079e2f9a808c634f744769dbb1d17
4 changes: 2 additions & 2 deletions crates/stdlib/src/sqlite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ mod _sqlite {
type Args = ConnectArgs;

fn init(zelf: PyRef<Self>, args: Self::Args, vm: &VirtualMachine) -> PyResult<()> {
let was_initialized = Radium::swap(&zelf.initialized, false, Ordering::Relaxed);
let was_initialized = Radium::swap(&zelf.initialized, false, Ordering::AcqRel);

// Reset factories to their defaults, matching CPython's behavior.
zelf.reset_factories(vm);
Expand Down Expand Up @@ -931,7 +931,7 @@ mod _sqlite {

let mut guard = zelf.db.lock();
*guard = Some(db);
Radium::store(&zelf.initialized, true, Ordering::Relaxed);
Radium::store(&zelf.initialized, true, Ordering::Release);
Ok(())
}
}
Expand Down
Loading