Skip to content

Replace compiler::source module with ruff_source_file #6016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Jul 22, 2025
Merged

Replace compiler::source module with ruff_source_file #6016

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ff541b
Replace `compiler::source`` with ruff
ShaharNaveh Jul 21, 2025
7f2620b
Require `ruff_source_file`
ShaharNaveh Jul 21, 2025
af382dd
Fix for windows
ShaharNaveh Jul 21, 2025
d82ede7
Restore `compiler::source`
ShaharNaveh Jul 22, 2025
776e57e
Deprecate `compiler::source`
ShaharNaveh Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Deprecate compiler::source
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jul 22, 2025
commit 776e57ea78cb2d7c3edae77e25d300ba973e8fad
6 changes: 3 additions & 3 deletions compiler/source/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "rustpython-compiler-source"
description = "RustPython Source and Index"
version.workspace = true
Copy link
Copy Markdown
Member

@youknowone youknowone Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to publish a deprecated version of this crate before removeing it from source code.

Suggested change
version.workspace = true
version = "0.5.0+deprecated"

Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofc, didn't realized that it was published, thought it was completely internal

description = "(DEPRECATED) RustPython Source and Index"
version = "0.5.0+deprecated"
authors.workspace = true
edition.workspace = true
rust-version.workspace = true
Expand All @@ -13,4 +13,4 @@ ruff_source_file = { workspace = true }
ruff_text_size = { workspace = true }

[lints]
workspace = true
workspace = true
Loading