Skip to content

Update operator from 3.13.5 #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Jul 11, 2025
Merged

Update operator from 3.13.5 #5935

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1fb196
Update operator from 3.13.5
ShaharNaveh Jul 10, 2025
9f7c299
Fix some of failing tests
ShaharNaveh Jul 10, 2025
770a000
Skip failing tests
ShaharNaveh Jul 11, 2025
a3ae24e
Override test methods instead of skipping them
ShaharNaveh Jul 11, 2025
402dbec
fmt
ShaharNaveh Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip failing tests
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jul 11, 2025
commit 770a00079c494643acd1df41b852ff2b523c9249
12 changes: 12 additions & 0 deletions Lib/test/test_operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,10 @@ def test_dunder_is_original(self):

@support.requires_docstrings
def test_attrgetter_signature(self):
Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to mark those signature tests with unittest.expectedFailure but then the test fails on "UNEXPECTED SUCCESS", very strange.

I have tried to mess with defining __text_signature__ but I'm guessing that I'm doing something wrong because it completely ignores it. I would appreciate any suggestion that you have:)

Copy link
Copy Markdown
Member

@youknowone youknowone Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is a base class of multiple other tests

# TODO: RUSTPYTHON fails only when running inside COperatorTestCase
if type(self).__name__ == 'COperatorTestCase':
self.skipTest("TODO: RUSTPYTHON")
Copy link
Copy Markdown
Member

@youknowone youknowone Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way of handling makes hard to fix it when it is actually fixed.
I know we have a few tests having similar patterns. They must be also fixed.

A recommended pattern is adding another test function under COperatorTestCase.

class COperatoorTestCase(...):  # existing code

    # TODO: RUSTPYTHON
    def test_attrgetter_signature(self):
        super().test_attrgetter_signature()

Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way of handling makes hard to fix it when it is actually fixed. I know we have a few tests having similar patterns. They must be also fixed.

sure, np


operator = self.module
sig = inspect.signature(operator.attrgetter)
self.assertEqual(str(sig), '(attr, /, *attrs)')
Expand All @@ -613,6 +617,10 @@ def test_attrgetter_signature(self):

@support.requires_docstrings
def test_itemgetter_signature(self):
# TODO: RUSTPYTHON fails only when running inside COperatorTestCase
if type(self).__name__ == 'COperatorTestCase':
self.skipTest("TODO: RUSTPYTHON")

operator = self.module
sig = inspect.signature(operator.itemgetter)
self.assertEqual(str(sig), '(item, /, *items)')
Expand All @@ -621,6 +629,10 @@ def test_itemgetter_signature(self):

@support.requires_docstrings
def test_methodcaller_signature(self):
# TODO: RUSTPYTHON fails only when running inside COperatorTestCase
if type(self).__name__ == 'COperatorTestCase':
self.skipTest("TODO: RUSTPYTHON")

operator = self.module
sig = inspect.signature(operator.methodcaller)
self.assertEqual(str(sig), '(name, /, *args, **kwargs)')
Expand Down
Loading