Skip to content

more typing #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 9 commits into from
Jun 26, 2025
Merged

more typing #5840

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bea5095
rename typing
youknowone Jun 26, 2025
b0c7f94
No test code modification rules
youknowone Jun 26, 2025
f0d9e1c
remove orphan TODOs
youknowone Jun 26, 2025
323171d
mro_entires
youknowone Jun 26, 2025
667d2a6
typing module name
youknowone Jun 26, 2025
0a75904
typing_subst
youknowone Jun 26, 2025
c2f8d5b
typing.override
youknowone Jun 26, 2025
d6e04aa
Comparable for typing
youknowone Jun 25, 2025
166c7bc
remove to_owned() from typing
youknowone Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
No test code modification rules
  • Loading branch information
@youknowone
youknowone committed Jun 26, 2025
commit b0c7f944db9268a6b78f6bea4dff7a0baf8a14b0
21 changes: 21 additions & 0 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,27 @@ cargo run --features jit
cargo run --features ssl
```

## Test Code Modification Rules

**CRITICAL: Test code modification restrictions**
- NEVER comment out or delete any test code lines except for removing `@unittest.expectedFailure` decorators and upper TODO comments
- NEVER modify test assertions, test logic, or test data
- When a test cannot pass due to missing language features, keep it as expectedFailure and document the reason
- The only acceptable modifications to test files are:
1. Removing `@unittest.expectedFailure` decorators and the upper TODO comments when tests actually pass
2. Adding `@unittest.expectedFailure` decorators when tests cannot be fixed

**Examples of FORBIDDEN modifications:**
- Commenting out test lines
- Changing test assertions
- Modifying test data or expected results
- Removing test logic

**Correct approach when tests fail due to unsupported syntax:**
- Keep the test as `@unittest.expectedFailure`
- Document that it requires PEP 695 support
- Focus on tests that can be fixed through Rust code changes only

## Documentation

- Check the [architecture document](architecture/architecture.md) for a high-level overview
Expand Down