Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Update our fork with upstream changes#4

Merged
Brantone merged 20 commits into
Roblox:masterfrom
Brantone:master
May 24, 2019
Merged

Update our fork with upstream changes#4
Brantone merged 20 commits into
Roblox:masterfrom
Brantone:master

Conversation

@Brantone

Copy link
Copy Markdown

No description provided.

@Brantone
Brantone requested a review from zirkov May 22, 2019 18:19
Comment thread metadata.rb
description 'Recipes and resources for installing Java and managing certificates'
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
version '4.9000.0'
version '4.9001.0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd have to be extra careful about version clashes again

Comment thread Dangerfile
@@ -1,14 +1,16 @@
# Reference: http://danger.systems/reference.html

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an awesome tool, we have to think about adding it to our projects!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, definitely worth adding it elsewhere 👍

@zirkov

zirkov commented May 23, 2019

Copy link
Copy Markdown

@Brantone I don't have write access so would leave the merge to you

@Brantone

Copy link
Copy Markdown
Author

Added applicable team to "Write"

@Brantone
Brantone merged commit c1b909b into Roblox:master May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants