Skip to content

Start rotating through all images - #17315

Merged
Travis Plunk (TravisEz13) merged 11 commits into
PowerShell:masterfrom
TravisEz13:containers-step3
May 12, 2022
Merged

Start rotating through all images#17315
Travis Plunk (TravisEz13) merged 11 commits into
PowerShell:masterfrom
TravisEz13:containers-step3

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented May 11, 2022

Copy link
Copy Markdown
Member

PR Summary

  • Start rotating through all images
    • Add a parameter to select the image you want in manual run
    • If an image has a problem, it can be disabled in the meta.json for than image in the docker repo.
  • Fix problem with the fallback seed for non-PR runs
    • old seed never changed. I'm now using the day of year.

PR Context

PR Checklist

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo, one comment

Comment thread build.psm1 Outdated
} elseif ($environment.IsFedora -or (Get-Command -Name dnf -CommandType Application -ErrorAction SilentlyContinue)) {
"dnf install -y -q"
} else {
} elseif (Get-Command -Name dnf -CommandType Application -ErrorAction SilentlyContinue) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this - i think this line is essentially the same as line 1964. Are you looking for where there is no command dnf? - that would be !(get-command ...).

Comment thread tools/ci.psm1 Outdated
Comment thread build.psm1 Outdated
Travis Plunk (TravisEz13) and others added 2 commits May 11, 2022 16:06
Co-authored-by: James Truher [MSFT] <jimtru@microsoft.com>
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 88 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +50 -38
Percentile : 35.2%

Total files changed: 4

Change summary by file extension:
.yml : +11 -34
.psm1 : +39 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13
Travis Plunk (TravisEz13) merged commit ba6fbe9 into PowerShell:master May 12, 2022
@TravisEz13
Travis Plunk (TravisEz13) deleted the containers-step3 branch May 12, 2022 17:03
@ghost

Copy link
Copy Markdown

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
* Use day of week for fallback seed

* Use new properties to select CI image

* move container selection code into

* use parameter

* fix azDO variable refernce

* move container name left in non-PR build name

* Use get-command to detect package manager

* update dependencies in build.psm1

* Add RHEL to WSMan support function

* Update build.psm1

* Update tools/ci.psm1

Co-authored-by: James Truher [MSFT] <jimtru@microsoft.com>

Co-authored-by: James Truher [MSFT] <jimtru@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants