Fixed package names verification to support multi-digit versions - #17220
Merged
Travis Plunk (TravisEz13) merged 1 commit intoApr 29, 2022
Merged
Conversation
…git versions Fixed package names verification to support multi-digit versions. Currently "Validate RPM package names" release step is failing because of version "7.0.10" in these examples: WARNING: powershell-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Dongbo Wang (daxian-dbw)
approved these changes
Apr 28, 2022
Travis Plunk (TravisEz13)
approved these changes
Apr 29, 2022
Travis Plunk (TravisEz13)
enabled auto-merge (squash)
April 29, 2022 00:05
|
🎉 Handy links: |
|
🎉 Handy links: |
Dongbo Wang (daxian-dbw)
pushed a commit
that referenced
this pull request
Apr 7, 2023
) Fixed package names verification to support multi-digit versions. Currently "Validate RPM package names" release step is failing because of version "7.0.10" in these examples: WARNING: powershell-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
…erShell#17220) Fixed package names verification to support multi-digit versions. Currently "Validate RPM package names" release step is failing because of version "7.0.10" in these examples: WARNING: powershell-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.centos.8.x86_64.rpm is not a valid package name WARNING: powershell-lts-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Copying this change from release branch of v7.0.10
PR Context
Fixed package names verification to support multi-digit versions.
Currently "Validate RPM package names" release step is failing because of version "7.0.10" in these examples:
WARNING: powershell-7.0.10-1.centos.8.x86_64.rpm is not a valid package name
WARNING: powershell-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name
WARNING: powershell-lts-7.0.10-1.centos.8.x86_64.rpm is not a valid package name
WARNING: powershell-lts-7.0.10-1.rhel.7.x86_64.rpm is not a valid package name
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).