Skip to content

Make mariner packages Framework dependent - #17151

Merged
Travis Plunk (TravisEz13) merged 9 commits into
PowerShell:masterfrom
TravisEz13:mariner3
Apr 21, 2022
Merged

Make mariner packages Framework dependent#17151
Travis Plunk (TravisEz13) merged 9 commits into
PowerShell:masterfrom
TravisEz13:mariner3

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Apr 13, 2022

Copy link
Copy Markdown
Member

PR Summary

  • Make mariner packages Framework dependent

PR Context

PR Checklist

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 73 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +66 -7
Percentile : 29.2%

Total files changed: 3

Change summary by file extension:
.psm1 : +60 -7
.json : +6 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TravisEz13

Copy link
Copy Markdown
Member Author

needs more stability before backport decision can be made.

@ghost

Copy link
Copy Markdown

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13

Copy link
Copy Markdown
Member Author

/backport to release/v7.2.5

@github-actions

github-actions Bot commented May 23, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/v7.2.5: https://github.com/PowerShell/PowerShell/actions/runs/2374309753

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions

Copy link
Copy Markdown
Contributor

Travis Plunk (@TravisEz13) backporting to release/v7.2.5 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Add package mapping for mariner
Applying: make mariner ready to run
Applying: add fixdep rpm
Using index info to reconstruct a base tree...
M	tools/packaging/packaging.psm1
Falling back to patching base and 3-way merge...
Auto-merging tools/packaging/packaging.psm1
CONFLICT (content): Merge conflict in tools/packaging/packaging.psm1
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 add fixdep rpm
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@adityapatwardhan

Copy link
Copy Markdown
Member

/backport to release/v7.2.5

@github-actions

github-actions Bot commented May 24, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/v7.2.5: https://github.com/PowerShell/PowerShell/actions/runs/2380365803

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants