Do not generate clean block in proxy command when the feature is disabled - #17112
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Paul Higinbotham (PaulHigin)
left a comment
There was a problem hiding this comment.
LGTM
|
This breaks JEA as it uses RestrictedSessions, so we should consider for backport. |
|
The |
|
🎉 Handy links: |
PR Summary
Fix #17110
When the
PSCleanBlockexperimental feature is not enabled,ProxyCommand.Createshould not generate the clean block for the proxy function.After the fix,
when the feature is disabled, generated proxy function for
Get-Commanddoesn't have thecleanblock in it:When the feature is enabled, the generated proxy function for
Get-Commandhas thecleanblock in it:PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.