Skip to content

Fix version parsing in bootstrapper - #17099

Closed
Jakub Jareš (nohwnd) wants to merge 1 commit into
PowerShell:masterfrom
nohwnd:fixup-dotnet-version-parsing
Closed

Fix version parsing in bootstrapper#17099
Jakub Jareš (nohwnd) wants to merge 1 commit into
PowerShell:masterfrom
nohwnd:fixup-dotnet-version-parsing

Conversation

@nohwnd

Copy link
Copy Markdown
Collaborator

PR Summary

Some versions of .NET preview were released with version that don't have a number following the preview suffix, and your pattern won't match them correctly. It will include spaces and fail with FormatException when parsing. The pattern is unnecessarily strict about the format, and not properly escaped. Replacing the pattern with simpler one, and trimming whitespace.

image

The existing pattern \d*.\d*.\d*(-\w*\.\d*.\d*.\d*)? does not escape the dots between numbers, and so the last . will match space.

image

PR Context

I have many .NET previews installed and don't want to remove them from my system to be able to build PS.

PR Checklist

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 4 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +3 -1
Percentile : 1.6%

Total files changed: 1

Change summary by file extension:
.psm1 : +3 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@nohwnd

Copy link
Copy Markdown
Collaborator Author

General question around this, is the version parsed like this on purpose to know the latest exact version installed on the system?

I remember having problems when my version is newer than what PowerShell needs, but I haven't touched this repo for a while, so I don't remember the exact details.

I'd propose using dotnet --version, which will look at your global.json and resolve a version based on your settings there, with optional rolling forward (default is upgrade within minor version). Getting the version from that you know that it matches your global json, and can build your solution, even if it is slightly newer. Otherwise, you will get an error, which is also pretty descriptive.

@ghost ghost added the Review - Needed The PR is being reviewed label Apr 9, 2022
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@nohwnd

Copy link
Copy Markdown
Collaborator Author

Ilya (@iSazonov) Friendly ping on this.

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 20, 2022
@TravisEz13
Travis Plunk (TravisEz13) enabled auto-merge (squash) April 20, 2022 21:46
@TravisEz13

This comment was marked as outdated.

1 similar comment
@TravisEz13

Copy link
Copy Markdown
Member

/rebase

@ghost ghost added the Review - Needed The PR is being reviewed label Apr 29, 2022
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw

Copy link
Copy Markdown
Member

Travis Plunk (@TravisEz13) I think this one can be superseded by #17198

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 29, 2022
@nohwnd

Copy link
Copy Markdown
Collaborator Author

Yup, it is the same fix. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants