Skip to content

Do not pull dotnet updates from internal feed. - #17007

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
JamesWTruher:updatedotnetfix02
Mar 18, 2022
Merged

Do not pull dotnet updates from internal feed.#17007
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
JamesWTruher:updatedotnetfix02

Conversation

@JamesWTruher

Copy link
Copy Markdown
Collaborator

PR Summary

We've been getting an error in our GitHub actions because we are attempting to update dotnet from an internal feed but the url to do so is not configured. We should not be pulling from an internal feed.

PR Context

PR Checklist

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.yml : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw

Copy link
Copy Markdown
Member

The -bnot test failed again 😦

cannot convert the "ns_9c3a4441a0e243e2b1e3e1b274e881a6.E_sbyte" value of type "System.String" to type "System.Type".

@adityapatwardhan

Copy link
Copy Markdown
Member

Re-running the test.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 965095e into PowerShell:master Mar 18, 2022
@daxian-dbw Dongbo Wang (daxian-dbw) added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log CL-Test Indicates that a PR should be marked as a test change in the Change Log and removed CL-Test Indicates that a PR should be marked as a test change in the Change Log labels Mar 18, 2022
@ghost

Copy link
Copy Markdown

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small WG-Maintainers-Build specific to affecting the build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants