Skip to content

Fix Untill typo in names of method - #17003

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
al-cheb:fix-untill-typo-in-methods
Mar 18, 2022
Merged

Fix Untill typo in names of method#17003
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
al-cheb:fix-untill-typo-in-methods

Conversation

@al-cheb

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

Fix Untill typo in files:

OutGridViewCommand.cs:148:      _windowProxy.BlockUntillClosed();         -> BlockUntilClosed()
OutWindowProxy.cs:233:          internal void BlockUntillClosed()         -> BlockUntilClosed()
TypeTable.cs:142:               SkipUntillNodeEnd(_reader.LocalName);     -> SkipUntilNodeEnd
TypeTable.cs:146:               private void SkipUntillNodeEnd(string nodeName)     -> SkipUntilNodeEnd
TypeTable.cs:152:               SkipUntillNodeEnd(nodeName);     ->  SkipUntilNodeEnd

PR Checklist

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 10 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +5 -5
Percentile : 4%

Total files changed: 3

Change summary by file extension:
.cs : +5 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 9c44c1c into PowerShell:master Mar 18, 2022
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Mar 18, 2022
@al-cheb
Aleksandr Chebotov (al-cheb) deleted the fix-untill-typo-in-methods branch March 18, 2022 21:37
@ghost

Copy link
Copy Markdown

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants