Update telemetry to use "na" instead of empty string - #16950
Closed
Steve Lee (SteveL-MSFT) wants to merge 2 commits into
Closed
Update telemetry to use "na" instead of empty string#16950Steve Lee (SteveL-MSFT) wants to merge 2 commits into
Steve Lee (SteveL-MSFT) wants to merge 2 commits into
Conversation
Steve Lee (SteveL-MSFT)
requested review from
James Truher (JamesWTruher) and
Travis Plunk (TravisEz13)
March 3, 2022 18:57
This comment was marked as outdated.
This comment was marked as outdated.
Steve Lee (SteveL-MSFT)
force-pushed
the
roleinstance
branch
from
March 4, 2022 23:09
1916c19 to
e296523
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Member
|
James Truher (@JamesWTruher) and Travis Plunk (@TravisEz13) Can one of you please take a look? |
Member
Author
|
Closing in favor of #16981 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
It seems that an empty string will still result in AppInsights using the node name. Instead, we'll populate
the roleinstance member with "na" indicating not applicable. This is used instead of a guid as we're not using this information (we have a separate guid already for the session) and to save on bytes being transferred.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).