Custom remote connections - #16859
Closed
Paul Higinbotham (PaulHigin) wants to merge 55 commits into
Closed
Conversation
…gin/PowerShell into custom_remote_connections
Paul Higinbotham (PaulHigin)
requested review from
Steve Lee (SteveL-MSFT),
Dongbo Wang (daxian-dbw) and
Ilya (iSazonov)
February 8, 2022 22:16
…gin/PowerShell into custom_remote_connections
Paul Higinbotham (PaulHigin)
requested review from
Travis Plunk (TravisEz13),
Aditya Patwardhan (adityapatwardhan) and
Andrew (anmenaga)
as code owners
February 24, 2022 23:52
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Paul Higinbotham (PaulHigin)
removed request for
Aditya Patwardhan (adityapatwardhan) and
Andrew (anmenaga)
February 25, 2022 16:46
Paul Higinbotham (PaulHigin)
requested review from
Jordan Borean (jborean93)
and removed request for
Ilya (iSazonov)
February 25, 2022 16:48
Contributor
Author
|
Created new PR with only custom remote connection changes (#16923). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR implements the Custom Remote Connections RFC:
https://github.com/PowerShell/PowerShell-RFC/blob/master/Archive/Draft/RFC0063-Custom-Remote-Connections.md
PR Context
These changes open up the internal PowerShell remoting API so that custom connections can be created as PowerShell modules. This PR does not introduce any new functions, and instead selectively makes some previously internal APIs public so that third parties can create custom remote connections without modifying PowerShell core engine code. See the above RFC for more details.
A new module repo has been created to serve as an example custom connection, by using the newly public API to create an SSH custom remote connection.
https://github.com/PaulHigin/SSHRemotingConnection
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).