Reinstate debugging API lost in #10338 - #10808
Merged
Aditya Patwardhan (adityapatwardhan) merged 5 commits intoOct 30, 2019
Merged
Reinstate debugging API lost in #10338#10808Aditya Patwardhan (adityapatwardhan) merged 5 commits into
Aditya Patwardhan (adityapatwardhan) merged 5 commits into
Conversation
Paul Higinbotham (PaulHigin)
approved these changes
Oct 16, 2019
Paul Higinbotham (PaulHigin)
left a comment
Paul Higinbotham (PaulHigin)
left a comment
Contributor
There was a problem hiding this comment.
LGTM, except I feel we should use the newer style for the overrides.
Collaborator
There was a problem hiding this comment.
Rob Holt (@rjmholt), your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/building/internals.md.https://cmake.org/download/ should work
retry of URL failed with error: Response status code does not indicate success: 500 (Internal Server Error).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 117
117: throw "retry of URL failed with error: $($_.Exception.Message)"
Collaborator
There was a problem hiding this comment.
Rob Holt (@rjmholt), your last commit had 1 failures in PowerShell-CI-windows
TestAppDomainProcessExitEvenHandlerNotLeaking
Assert.DoesNotContain() Failure
Found: (filter expression)
In value: Delegate[] [EventHandler { Method = Void DisposeOnShutdown(System.Object, System.EventArgs), Target = null }, EventHandler { Method = Void CurrentDomain_ProcessExit(System.Object, System.EventArgs), Target = null }]
at PSTests.Sequential.RunspaceTests.TestAppDomainProcessExitEvenHandlerNotLeaking() in D:\a\1\s\test\xUnit\csharp\test_Runspace.cs:line 127
Collaborator
|
Rob Holt (@rjmholt) Please rebase to pass CIs. |
Rob Holt (rjmholt)
force-pushed
the
reinstate-setbreakpoint
branch
from
October 17, 2019 20:20
b8f8ced to
4b796e8
Compare
Collaborator
There was a problem hiding this comment.
Rob Holt (@rjmholt), your last commit had 1 failures in PowerShell-CI-windows
TestAppDomainProcessExitEvenHandlerNotLeaking
Assert.DoesNotContain() Failure
Found: (filter expression)
In value: Delegate[] [EventHandler { Method = Void DisposeOnShutdown(System.Object, System.EventArgs), Target = null }, EventHandler { Method = Void CurrentDomain_ProcessExit(System.Object, System.EventArgs), Target = null }]
at PSTests.Sequential.RunspaceTests.TestAppDomainProcessExitEvenHandlerNotLeaking() in D:\a\1\s\test\xUnit\csharp\test_Runspace.cs:line 127
Collaborator
There was a problem hiding this comment.
Rob Holt (@rjmholt), your last commit had 1 failures in PowerShell-CI-windows
TestAppDomainProcessExitEvenHandlerNotLeaking
Assert.DoesNotContain() Failure
Found: (filter expression)
In value: Delegate[] [EventHandler { Method = Void DisposeOnShutdown(System.Object, System.EventArgs), Target = null }, EventHandler { Method = Void CurrentDomain_ProcessExit(System.Object, System.EventArgs), Target = null }]
at PSTests.Sequential.RunspaceTests.TestAppDomainProcessExitEvenHandlerNotLeaking() in D:\a\1\s\test\xUnit\csharp\test_Runspace.cs:line 127
Rob Holt (rjmholt)
force-pushed
the
reinstate-setbreakpoint
branch
from
October 18, 2019 15:53
4b796e8 to
af70d02
Compare
Ilya (iSazonov)
approved these changes
Oct 18, 2019
Ilya (iSazonov)
added
the
CL-CodeCleanup
Member
|
Rob Holt (@rjmholt) Please fix the code factor reported issues. |
Collaborator
Author
Remaining issues are as they were in the codebase before the API was taken out. |
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds SetBreakpoints back
PR Context
#10338 removed the
SetBreakpointspublic API, which is required for cross-PowerShell debugging.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.