Response is closed after decoder fails#668
Merged
velo merged 1 commit intoOpenFeign:masterfrom May 5, 2018
Merged
Conversation
Contributor
|
Can you please attach a unit test also ? |
Previously a decoder failure resulting in an exception would fail to close responses when "doNotCloseAfterDecode" was enabled.
carterkozak
force-pushed
the
close_response_after_decode_error
branch
from
d473c5c to
6ef79dd
Compare
Author
|
Updated with a test that fails against master :-) |
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
Previously a decoder failure resulting in an exception would fail to close responses when "doNotCloseAfterDecode" was enabled.
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Previously a decoder failure resulting in an exception would fail to close responses when "doNotCloseAfterDecode" was enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a decoder failure resulting in an exception would
fail to close responses when "doNotCloseAfterDecode" was enabled.