This repository was archived by the owner on Feb 3, 2023. It is now read-only.
Add the 'tile' unit of QLength#478
Merged
Merged
Conversation
GitHub deprecated the git:// protocol on Jan 11, 2022. Since then, CI runs and submodule updates just time out because the URL cannot be found. Source: https://github.blog/2021-09-01-improving-git-protocol-security-github/.
The VRC field is 6 by 6 tiles. This could be convenient for teams coding their auton movements relative to a certain number of field tiles. See this VexForum post for reference: https://www.vexforum.com/t/tipping-point-season-code-request/102621/8?u=karmanyaahm .
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 88.69% 88.72% +0.03%
==========================================
Files 140 140
Lines 5880 5880
==========================================
+ Hits 5215 5217 +2
+ Misses 665 663 -2 |
This was referenced May 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if you guys want this, but it's a pretty small change if you do:
Description of the Change
Add a unit called 'tile' = 24 inches. Just like length values to chassis PID and other places can be 24_in, it can be done with 1_tile.
Motivation
The VRC field is 6 by 6 tiles. This could be convenient for teams coding their auton movements relative to a certain number of field tiles rather than just inches.
See this VexForum post: https://www.vexforum.com/t/tipping-point-season-code-request/102621/8?u=karmanyaahm .
Possible Drawbacks
I don't think there's any since it's not removing or changing anything
Verification Process
I've been using an equivalent of this in my competition code all year, and this is a pretty small change.
Another cool thing I do in my code, is printing odometry values (OdomState::str) as _tile instead of meter. 6 tiles is more intuitive than seeing 3.6576 m (the field dimensions). However, I'm unsure of how to implement that without any regressions, if you guys think it's a good idea, I can work on it with some advice.