Skip to content

openblas: Enable loongarch64-linux #229073

Merged
wegank merged 2 commits intoNixOS:masterfrom
jackyliu16:loongarch-support
May 1, 2023
Merged

openblas: Enable loongarch64-linux #229073
wegank merged 2 commits intoNixOS:masterfrom
jackyliu16:loongarch-support

Conversation

@jackyliu16
Copy link
Copy Markdown
Member

@jackyliu16 jackyliu16 commented Apr 30, 2023

Description of changes

Enable loongarch64-linux platform in

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 30, 2023
@jackyliu16 jackyliu16 marked this pull request as draft April 30, 2023 07:38
@github-actions github-actions Bot removed 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels Apr 30, 2023
wegank
wegank reviewed Apr 30, 2023
View reviewed changes
Comment thread pkgs/development/libraries/science/math/openblas/default.nix Outdated
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 30, 2023
@jackyliu16 jackyliu16 assigned jackyliu16 and unassigned jackyliu16 Apr 30, 2023
@wegank
Copy link
Copy Markdown
Member

wegank commented Apr 30, 2023 •
edited
Loading

@ofborg build pkgsCross.loongarch64-linux.openblas

@jackyliu16 jackyliu16 marked this pull request as ready for review April 30, 2023 09:06
@wegank

This comment was marked as outdated.

Sign in to view
wegank
wegank reviewed Apr 30, 2023
View reviewed changes
Comment thread pkgs/development/libraries/science/math/openblas/default.nix Outdated
@wegank wegank force-pushed the loongarch-support branch from 745e8b8 to 7dcfd3c Compare April 30, 2023 10:58
@wegank wegank force-pushed the loongarch-support branch from 7dcfd3c to c8f1166 Compare April 30, 2023 10:59
@jackyliu16
Copy link
Copy Markdown
Member Author

jackyliu16 commented Apr 30, 2023 •
edited
Loading

A little bit weird, after update the config, the problems I face on my side seem to be gone --that one which blas-3 no support loongarch arch-- and haven't any kinds of error --change into one relating to python setuptools and wheels-- , thus i just past it away. (
No module named '_sysconfigdata__linux_loongarch64-linux-gnu'

@wegank
Copy link
Copy Markdown
Member

wegank commented Apr 30, 2023 •
edited
Loading

To build pkgsCross.loongarch64-linux.python3Packages.setuptools, just add the patch python/cpython#30939 to pkgs/development/interpreters/python/cpython/default.nix.

(And that deserves another PR, I think.)

@jackyliu16
Copy link
Copy Markdown
Member Author

jackyliu16 commented Apr 30, 2023 •
edited
Loading

To build pkgsCross.loongarch64-linux.python3Packages.setuptools, just add the patch python/cpython#30939 to pkgs/development/interpreters/python/cpython/default.nix.

(And that deserves another PR, I think.)

yes, i know
Just wondering if it's going to be a little bit of a problem after the merger, although it doesn't seem to be going to happen at the moment

Even so, let me have a try :-)

@wegank wegank merged commit 623ae50 into NixOS:master May 1, 2023
@alyssais alyssais added the 6.topic: exotic Exotic hardware or software platform label May 4, 2023
@wegank wegank added the 6.topic: loongarch64 LoongArch, a new RISC ISA used on Loongson CPUs label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@dasJ dasJ Awaiting requested review from dasJ

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@alyssais alyssais Awaiting requested review from alyssais

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

6.topic: exotic Exotic hardware or software platform 6.topic: loongarch64 LoongArch, a new RISC ISA used on Loongson CPUs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackyliu16 @wegank @alyssais