fix(ios/bottom-navigation): Changing tabs programatically messes up styles#8160
Merged
vtrifonov merged 6 commits intoNativeScript:masterfrom Jan 10, 2020
Conversation
…ectedIndex changed handler
Contributor
Author
|
@MartoYankov I see that you supervise the TabView component developing, maybe you could check this small PR, which fix really annoying for iOS developer issue. |
Contributor
|
Hi @ycherniavskyi |
Contributor
Author
|
@vakrilov thank you for clarification, so I am waiting for the 6.3 patch release. |
vtrifonov
approved these changes
Jan 10, 2020
This was referenced Mar 20, 2020
This was referenced Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently, TabStrip items event emitting only when user click on UITabBar within processing
tabBarControllerDidSelectViewControllerhandler method ofUITabBarControllerDelegateclass. That is why whenselectedIndexproperty changed programmatically TabStrip styling messed up.What is the new behavior?
Current fix, just move TabStrip items event emitting into
onSelectedIndexChangedhandler, which called on processingtabBarControllerDidSelectViewControllerhandler method (within_onViewControllerShownmethod) and on processingselectedIndexproperty changed programmatically.Fixes/Implements/Closes #7667.