fix(ios): safe area handling in scrollview#6561
Merged
MartoYankov merged 2 commits intomasterfrom Nov 15, 2018
Merged
Conversation
MartoYankov
requested review from
ADjenkov,
SvetoslavTsenov,
manoldonev,
vakrilov and
vchimev
ghost
added
the
vchimev
approved these changes
Nov 15, 2018
manoldonev
approved these changes
Nov 15, 2018
SvetoslavTsenov
approved these changes
Nov 15, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6439
Fixes NativeScript/nativescript-angular#1593
Fixes NativeScript/nativescript-angular#1599
Both tests should scroll to bottom and compare image.
Bonus test on issue-ng-repo-1599: scroll one horizontal scrollview to end and compare image first.