fix(android): IllegalStateException with tabview&nested frames#6495
Merged
manoldonev merged 3 commits intomasterfrom Nov 5, 2018
Merged
fix(android): IllegalStateException with tabview&nested frames#6495manoldonev merged 3 commits intomasterfrom
manoldonev merged 3 commits intomasterfrom
Conversation
ghost
added
the
Contributor
Author
|
test --ignore uitests_android ngapps_android api19 api23 api28 |
Contributor
Author
|
test --ignore uitests_android ngapps_android api19 api23 api28 |
MartoYankov
approved these changes
Nov 2, 2018
manoldonev
force-pushed
the
mdonev/child-already-has-a-parent-fix
branch
from
402414f to
cf59ca9
Compare
Contributor
|
test ngapps#svetoslavtsenov/enable-naviagtion-tests-android build_nativescript_angular#svetoslavtsenov/enable-naviagtion-tests-android |
Contributor
|
test ngapps#svetoslavtsenov/enable-naviagtion-tests-android build_nativescript-angular#svetoslavtsenov/enable-naviagtion-tests-android |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6490
Related to: #6339
Related to: #6421
This fix was originally applied with #6339 but was later reworked with #6421 (basically the part in frame.android.ts where disposing the fragments is performed after super.unloaded(...) logic).
The original fix did not work properly when called in onDestroyView(...) as it essentially removed the fragment view too early hence breaking exit transition. I actually tested onDestroy(...) then as well but due to a different bug addressed with #6421 and #6489 (essentially we need to cache and restore animators because of the simulated first navigation) onDestroyView(...) and onDestroy(...) were called at the same time (now onDestroy(...) is called after the actual exit transition is finished which means we can use it to detach the native view from its parent).