Hey @shyamseshadri,

Thanks for the PR! The code looks good.

Would you mind adding a showcase of the new option along with the other prompt types in this test page.

Added the tests, and also added inputType phone in additio to number.

There was one unit test failing, but I'm pretty sure it was unrelated to my code

Test: LISTVIEW.test_scrollToIndex_should_coerce_larger_index_to_last_item_index FAILED: last element is visible Actual: (boolean). Expected: (boolean)

hey @vakrilov , let me know if this looks good or if you need me to make any other changes.

Thanks!
Tests and code looks good. I will inform you if there is any action needed from your side.

test

Hey @shyamseshadri - thanks again for the PR!
We are currently in a code-freeze phase for the NativeScript 5.0 release. This means it might take more time to merge PRs into master.

We will notify you if the is some action needed form your side.
Thanks for understanding and being awesome part of the NS community!

test

test

merging this -- agreed with @SvetoslavTsenov that he will update the images for the failing ui dialog tests: http://nsbuild01.telerik.com:8080/build/job/pr-composite-ns-core-modules/733/

Hi @shyamseshadri ,

Congratulations on being one of the winners in the {N} First-time contributors contest!

You can claim your prize by contacting us at nativescriptwinners[at]progress.com not later than Nov 30th 2018 . Make sure you send us the following info: 
👉Your full name 
👉Your email 
👉Your country or residence 

Best regards,
The NativeScript Team

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.