Skip to content

feat(vite): improved workspace and windows compatibility#10959

Open
NathanWalker wants to merge 41 commits intomainfrom
feat/vite-improvements
Open

feat(vite): improved workspace and windows compatibility#10959
NathanWalker wants to merge 41 commits intomainfrom
feat/vite-improvements

Conversation

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Nov 24, 2025

  • Improvements to project flavor handling, module resolution, and cross-platform compatibility in the Vite configuration and supporting utilities.
  • Polyfills are now resolved relative to the main entry directory, ensuring correct behavior in both monorepos and standalone projects, and import specifiers are normalized to POSIX style for consistency.

@nx-cloud
Copy link

nx-cloud bot commented Nov 24, 2025

View your CI Pipeline Execution ↗ for commit f6ad8e8

Command Status Duration Result
nx test apps-automated -c=ios ✅ Succeeded 2m 5s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-12 17:17:00 UTC

@NathanWalker NathanWalker force-pushed the feat/vite-improvements branch 4 times, most recently from a4a2258 to 74c041a Compare December 2, 2025 00:01
@NathanWalker NathanWalker force-pushed the feat/vite-improvements branch from 74c041a to 6de0d07 Compare December 4, 2025 18:06
@NathanWalker NathanWalker force-pushed the feat/vite-improvements branch from b6f85fc to 40788e3 Compare December 12, 2025 19:54
@NathanWalker NathanWalker marked this pull request as draft January 7, 2026 18:42
@NathanWalker NathanWalker marked this pull request as ready for review March 12, 2026 04:30
Type checking diagnostics come from the project's `tsconfig.json`. By default, the build follows `compilerOptions.noEmitOnError` to decide whether type errors should fail the build. If you want to override that behavior for Vite, pass a `typeCheck` option to the framework helper.
getItem(index: number): any;
}

export type RepeaterItemsLayout = View & Pick<LayoutBase, 'addChild' | 'removeChildren' | 'getChildrenCount' | 'getChildAt'>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NathanWalker Why not use LayoutBase directly here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants