Fixes Issue #332#333
Conversation
… that provided optional default implementation of IPipelineHook.
…inherit from PipelineHookBase, simplifies things a bit.
…ve tracked commits from it's cache.
…am for all pipeline hooks + tests
|
@damianh I could only look through it on my phone, but it looks good - can't see any flaws ATM. The only thing I've noticed is that apparently the decorator is not responsible for raising the PreCommit and PostCommit hooks. Those are raised directly by OptimisticEventStore, which I find a little asymmetric. Doesn't really have much to do with this pull request, though. |
|
Agreed, hence the leakyness of this. But.. its a narrow use case -
|
2 participants
Fixes Issue #332.
Adds OnPurge and OnStreamDelete to IPipelineHook. Key implementer is the OptimisticPipelineHook so that it's cache of tracked heads are cleaned up accordingly. The PipelineHooksAwarePersistanceDecorator is responsible for calling these additional extension points.
Honestly, feels a bit leaky to me, but can't think of a better way...