floodit: Tweaks, display "game ended" dialog and allow new game - #242
Merged
Merged
Conversation
Contributor
|
Awesome! |
Contributor
|
@pavelmachek would you mind also incrementing the version number? That way users will get an update notification :-) |
Contributor
Author
|
I attempted to increase the version. Hopefully I got it right. |
Contributor
Author
|
So... it worked, then I updated the version, and then it fails in unrelated test. I believe this is not my fault; tell me if you believe otherwise. |
Contributor
|
Awesome, thanks! Indeed, that must be something else - hundreds of tests nowadays, and concurrent pull requests, need to structure this better. Will merge, thanks again, keep it coming! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it less confusing. You can play more than one game now!