Skip to content

[Don't merge] Semver + header#32

Merged
icanzilb merged 2 commits into
mainfrom
marin_todorov/semver
Sep 8, 2022
Merged

[Don't merge] Semver + header#32
icanzilb merged 2 commits into
mainfrom
marin_todorov/semver

Conversation

@icanzilb

@icanzilb icanzilb commented Sep 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR:

  • Pin swift-markdown to the current commit hash
  • Removes the template headers from source
  • Cleans Package.swift from the swift-markdown branch names

Resolves #15

@icanzilb icanzilb self-assigned this Sep 8, 2022
@icanzilb

icanzilb commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator Author

Ooof, I got misled by this working locally but dependencies actually fail when the package is online and tagged:

Updated https://github.com/apple/swift-markdown.git (0.50s)
error: Dependencies could not be resolved because package 'markcodable' is required using a stable-version but 'markcodable' depends on an unstable-version package 'swift-markdown' and root depends on 'markcodable' 0.6.4.

@icanzilb icanzilb changed the title Semver + header [Don't merge] Semver + header Sep 8, 2022
@icanzilb

icanzilb commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator Author

Forked swift-markdown and swift-cmark, added semver tags and now can also semver MarkCodable:

swift build
Fetching https://github.com/markcodable/swift-cmark.git from cache
Fetching https://github.com/MarkCodable/swift-markdown from cache
Fetching https://github.com/MarkCodable/MarkCodable from cache
Fetched https://github.com/markcodable/swift-cmark.git (0.72s)
Fetched https://github.com/MarkCodable/MarkCodable (0.73s)
Computing version for https://github.com/MarkCodable/MarkCodable
Fetched https://github.com/MarkCodable/swift-markdown (0.73s)
Computed https://github.com/MarkCodable/MarkCodable at 0.6.5 (0.02s)
Computing version for https://github.com/markcodable/swift-markdown.git
Computed https://github.com/markcodable/swift-markdown.git at 0.100.1 (0.03s)
Computing version for https://github.com/markcodable/swift-cmark.git
Computed https://github.com/markcodable/swift-cmark.git at 0.100.1 (0.03s)
Creating working copy for https://github.com/MarkCodable/swift-markdown
Working copy of https://github.com/MarkCodable/swift-markdown resolved at 0.100.1
Creating working copy for https://github.com/markcodable/swift-cmark.git
Working copy of https://github.com/markcodable/swift-cmark.git resolved at 0.100.1
Creating working copy for https://github.com/MarkCodable/MarkCodable
Working copy of https://github.com/MarkCodable/MarkCodable resolved at 0.6.5
Building for debugging...
[3/3] Linking MCTest
Build complete! (2.43s)

@icanzilb
icanzilb merged commit b79f2e3 into main Sep 8, 2022
@icanzilb
icanzilb deleted the marin_todorov/semver branch September 8, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@icanzilb icanzilb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to resolve the semantic versioning vs apple-style release branches problem?

1 participant

@icanzilb