fix: detect node on react-native environments#87
Closed
simon-scherzinger wants to merge 1 commit into
Closed
Conversation
brettz9
reviewed
Oct 19, 2018
| }, | ||
| "react-native": { | ||
| "vm": false | ||
| }, |
Collaborator
There was a problem hiding this comment.
If React-Native doesn't support vm anyhow, what does this do?
Author
There was a problem hiding this comment.
This will tell reacts module bundling not to look for the vm module. Even though the module will not be used during runtime the bundler is still trying to find it.
Collaborator
|
I think I sometimes fail to get notifications for code comments, so just a ping to let you know I made a comment and would be happy to pull this if you could answer the question. |
Collaborator
|
Incorporated into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix JSONPath plus for react-native.
Currently it will fail since
vmis not available in react-native. When bundling JavaScript for react-native it will try to findvmwithout success (see change inpackage.json).During runtime it will fail since detecting of node will also be true in react-native (see change in
lib/jsonpath.js)Take care,
Simon