Skip to content

fix: field blueprint filters#428

Merged
jacobmanderson merged 7 commits into
masterfrom
jacob/fix-filters
Jan 7, 2026
Merged

fix: field blueprint filters#428
jacobmanderson merged 7 commits into
masterfrom
jacob/fix-filters

Conversation

@jacobmanderson
Copy link
Copy Markdown
Contributor

Summary

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Jira story/task is put into PR title
  • Code has been self-reviewed
  • Hard-to-understand areas have been commented
  • Documentation has been updated
  • My changes generate no new warnings
  • Unit tests have been added for base functionality and known edge cases
  • Any dependent changes have been merged and published in downstream modules

Sung96kim
Sung96kim previously approved these changes Jan 6, 2026
Copy link
Copy Markdown
Contributor

@Sung96kim Sung96kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a little bad removing the stuff that people can filter by for field bps

@jacobmanderson
Copy link
Copy Markdown
Contributor Author

feels a little bad removing the stuff that people can filter by for field bps

i agree, but we don't really have a nice way of getting both . if we really want it i can probably take some time to look into it.

@Sung96kim
Copy link
Copy Markdown
Contributor

I think at a minimum maybe docstring somewhere

Sung96kim
Sung96kim previously approved these changes Jan 7, 2026
Comment thread indico/filters/field_blueprints.py Outdated
@jacobmanderson jacobmanderson merged commit 24895fb into master Jan 7, 2026
1 check was pending
@jacobmanderson jacobmanderson deleted the jacob/fix-filters branch January 7, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants