[DEV-11651] Reduce base install size by making Msgpack, Numpy, and Pandas optional dependencies#314
Merged
Merged
Conversation
goatrocks
approved these changes
Sep 19, 2024
jacobmanderson
approved these changes
Dec 6, 2024
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make large dependencies like Numpy and Pandas optional to reduce the base install size of the client. These are required by only a handful of uncommon calls, yet represent 75% of the install size. This will better support customers who use the client in AWS Lambdas where they're limited to 250Mb.
Changelog
pillowas it appears to be unneeded.msgpackandnumpyoptional as they are only used for specific deserialization functions.indico-client[deserialization]orindico-client[all]extras.pandasoptional as it is only used for creating image datasets and retrieving exports.indico-client[datasets],indico-client[exports], orindico-client[all]extras.CreateDatasetmanipulated CSVs with the nativecsvmodule andDownloadExportreturned a CSV string instead of a dataframe.Type of change
Checklist: