This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Add installed_version_time to release time table schema#51
Merged
Conversation
| }, | ||
| { | ||
| "mode": "REQUIRED", | ||
| "mode": "NULLABLE", |
There was a problem hiding this comment.
Why was it required before and is this ok to be nullable?
Member
Author
There was a problem hiding this comment.
I was thinking it might be good to be less strict in the table schema in order to insert all the data records we collected. But now I feel like if those fields are Null then the row will be useless, so I changed them back to required. Thx!
enriquejosepadilla
approved these changes
Jul 19, 2018
Member
Author
|
CircleCI was not working this afternoon, manually run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.