Feature.ltm_ssl_cert_key - #626

hmm, that test passes locally, not sure what happened in build 335, but it didn't re-run when I closed and reopened this pull request. Ideas?

as per Slack comments, looking at the Jenkins logs it seems you are failing due to changes between v11 and v12:

https://gist.github.com/wojtek0806/c10a4de1d64ee65cc15096152779dafd#file-v11

https://gist.github.com/wojtek0806/036c0376df1f437f5d825699b3b04357#file-v12

I have looked at the code and just needs few removals and would be good to go:

You can remove these lines:

https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L54
https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L93
https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L113
https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L133
https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L154

As such replacement should be handled inside PathElement already:

https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/resource.py#L237

This is unnecessary in collections, it only has its use in sub-collections:

https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L50
https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L70
https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L89
https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L109
https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L129
https://github.com/jasonrahm/f5-common-python/blob/9cf557ea61a2d6b772983d55b3d033932985ed43/f5/bigip/tm/sys/file.py#L150

ok, those have been resolved, tested, and commited, @wojtek0806.

ok SHIP it!

@jasonrahm, @wojtek0806, @tar: Yo guys, just a note that I was getting local failures when running these tests because they use the OpenSSL library. It you add something that is not part of the Python standard library, go ahead and add it as a requirement to requirements.test.txt file to ensure everyone else has it when they try to run the tests.

Will do, sorry about that!